Skip to content

feat(binder): persist fractional GPU compute mode - #2047

Draft
davidLif wants to merge 1 commit into
codex/fractional-gpu-mode-schedulerfrom
codex/fractional-gpu-mode-binder
Draft

feat(binder): persist fractional GPU compute mode#2047
davidLif wants to merge 1 commit into
codex/fractional-gpu-mode-schedulerfrom
codex/fractional-gpu-mode-binder

Conversation

@davidLif

Copy link
Copy Markdown
Collaborator

Description

Stack PR 8/9 for GPU sharing migration.

Base: codex/fractional-gpu-mode-scheduler
Head: codex/fractional-gpu-mode-binder

This updates Binder and resource-reservation handling to persist typed fractional GPU compute mode data from BindRequests. It adjusts mocks, controller wiring, and resource-reservation tests for the typed fractional GPU group structure introduced earlier in the stack.

Related Issues

N/A

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)
  • Added a changelog fragment via make changelog (or applied the skip-changelog label). Do not edit CHANGELOG.md directly — pending fragments are folded into it at release time.

Breaking Changes

None.

Additional Notes

Validation run:

go test ./pkg/binder/binding ./pkg/binder/binding/resourcereservation ./pkg/binder/controllers

@davidLif
davidLif force-pushed the codex/fractional-gpu-mode-binder branch from 58a3cb7 to d7a4068 Compare August 10, 2026 10:02
@davidLif
davidLif force-pushed the codex/fractional-gpu-mode-binder branch from d7a4068 to 37eb874 Compare August 11, 2026 14:03
@davidLif
davidLif force-pushed the codex/fractional-gpu-mode-binder branch from 37eb874 to 6eb64cd Compare August 11, 2026 20:25
@davidLif
davidLif force-pushed the codex/fractional-gpu-mode-binder branch from 6eb64cd to 26bb9a7 Compare August 11, 2026 21:11
@davidLif
davidLif force-pushed the codex/fractional-gpu-mode-binder branch from 26bb9a7 to 9def77f Compare August 11, 2026 21:26
@davidLif
davidLif force-pushed the codex/fractional-gpu-mode-binder branch from 9def77f to 6cbd636 Compare August 11, 2026 22:04
@davidLif
davidLif force-pushed the codex/fractional-gpu-mode-binder branch from 6cbd636 to 65b7167 Compare August 11, 2026 22:13
@davidLif
davidLif force-pushed the codex/fractional-gpu-mode-binder branch from 65b7167 to 8bb1a9a Compare August 11, 2026 22:13
@davidLif
davidLif force-pushed the codex/fractional-gpu-mode-binder branch from 8bb1a9a to d146db2 Compare August 11, 2026 22:17
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

Total coverage: 54.6% -> 54.8% (delta 0.20%)

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/kai-scheduler/KAI-scheduler/pkg/binder/binding 67.92% (ø)
github.com/kai-scheduler/KAI-scheduler/pkg/binder/binding/resourcereservation 91.37% (-1.42%) 👎
github.com/kai-scheduler/KAI-scheduler/pkg/binder/binding/resourcereservation/mock 0.00% (ø)
github.com/kai-scheduler/KAI-scheduler/pkg/binder/controllers 46.85% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/kai-scheduler/KAI-scheduler/pkg/binder/binding/binder.go 67.92% (ø) 53 36 17
github.com/kai-scheduler/KAI-scheduler/pkg/binder/binding/resourcereservation/mock/resource_reservation_mock.go 0.00% (ø) 35 0 35
github.com/kai-scheduler/KAI-scheduler/pkg/binder/binding/resourcereservation/resource_reservation.go 91.37% (-1.42%) 255 (+19) 233 (+14) 22 (+5) 👎
github.com/kai-scheduler/KAI-scheduler/pkg/binder/controllers/bindrequest_controller.go 67.68% (ø) 99 67 32

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/kai-scheduler/KAI-scheduler/pkg/binder/binding/resourcereservation/resource_reservation_test.go

@davidLif
davidLif force-pushed the codex/fractional-gpu-mode-binder branch from d146db2 to d5c789f Compare August 13, 2026 11:32
@davidLif
davidLif force-pushed the codex/fractional-gpu-mode-binder branch from d5c789f to 7f194bc Compare August 17, 2026 06:39
Signed-off-by: davidLif <davidshani12@gmail.com>
@davidLif
davidLif force-pushed the codex/fractional-gpu-mode-binder branch from 7f194bc to 1b7c9c0 Compare August 17, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant